fix(reconcile): notify ownKeys subscribers on pure keyed trailing removal#2795
Open
tsushanth wants to merge 1 commit into
Open
fix(reconcile): notify ownKeys subscribers on pure keyed trailing removal#2795tsushanth wants to merge 1 commit into
tsushanth wants to merge 1 commit into
Conversation
…oval When keyed reconcile removes only trailing items, the early-exit branch skipped notifySelf because no element was rewritten (changed stayed false). Widen the guard to also fire when the array length changed, ensuring $TRACK subscribers are invalidated in both applyStateFast and applyStateSlow. Fixes solidjs#2773
🦋 Changeset detectedLatest commit: 54b2175 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When keyed
reconcileremoves only trailing items from an array (for example[{id:1},{id:2},{id:3}]shrinks to[{id:1},{id:2}]), the common-prefix loop advancesstartpast all matching items, which causesstart > newEndto be true and the early-exit branch to executeInside that branch, the two inner loops only run when there are new or updated items to write — there are none in a pure removal — so
changedstaysfalse,notifySelf(target)is skipped, and any memo that subscribed to the array'sownKeysvia$TRACKis never invalidatedThe length signal fires correctly, but that is a separate signal;
ownKeyssubscribers (whichcreateSelector, spread patterns, and anything using$TRACKdepend on) are silently staleThe same path exists in both
applyStateFastandapplyStateSlowFix: widen the
notifySelfguard to also fire when the array length changed, regardless of whether any element was rewritten in this passFixes #2773